Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeAlgo : Fix plug presets inheritance #5799

Merged

Conversation

pier-robot
Copy link

By getting the first output plug with presets, as opposed to just the first output plug, as this was causing incorrect inheritance on plugs with multiple outputs.

Internally at IE this came up when we had a plug that had been promoted, and then was being used in a couple of Expressions. In this case an Expression plug was being checked for presets as it came first in the outputs list.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

By getting the first outplug plug with presets, as opposed to just the
first output plug, as this was causing incorrect inheritance on plugs
with multiple outputs.
@johnhaddon johnhaddon merged commit da2c20b into GafferHQ:1.3_maintenance Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants